Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix](Nereids) string constant folding process regex delim by mistake #48783 #48822

Merged
merged 1 commit into from
Mar 10, 2025
Merged

branch-3.0: [fix](Nereids) string constant folding process regex delim by mistake #48783 #48822

merged 1 commit into from
Mar 10, 2025
+149 −31

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2025

Cherry-picked from #48783

@morrySnow
[fix](Nereids) string constant folding process regex delim by mistake (…
f0ab185 
…#48783)

### What problem does this PR solve?

Related PR: #40441

Problem Summary:

The delimiters in split-related string functions that have special
meanings in regular expressions should be escaped.

.$|()[{^?*+\
@github-actions github-actions bot requested a review from dataroaring as a code owner March 7, 2025 08:37
@Thearas
Copy link
Contributor

Thearas commented Mar 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 7, 2025
@dataroaring dataroaring reopened this Mar 7, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 7, 2025

run buildall

dataroaring
dataroaring approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 634f2d5 into branch-3.0 Mar 10, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48783-branch-3.0 branch March 10, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thearas @dataroaring @morrySnow